Removed "Pa" prefix where it is not necessary #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrochuk
force-pushed
the
users/anpetroc/removed_pa
branch
from
8364fc1 to
eb623f8
Compare
petrochuk
changed the title
mizrael
approved these changes
May 16, 2024
joem-msft
previously requested changes
May 16, 2024
There was a problem hiding this comment.
What is the issue you're trying to solve here? Please do not change anything in the PaYaml folders unless there is an actual feature that needs to be changed.
The PaYaml prefix in type names are by design.
- The need for a type prefix is to provide unambiguous type names in code when multiple namespaces are added via
usingstatements. This is the same issue we had to address the other day.
e.g. this assembly now has two YamlSerializer classes:
Microsoft.PowerPlatform.PowerApps.Persistence.PaYaml.Serialization.YamlSerializer
and
Microsoft.PowerPlatform.PowerApps.Persistence.Yaml.YamlSerializer - The name
PaYamlis designed to correlate with most of these files have the file extension.pa.yaml. - The
PaYamlin the namespace was intended to allow for the current OM and the new OM to live in the same assembly. It is a pragmatic design decision that allows for both OMs to be side-by-side at this time of transition. Eventually, the PaYaml namespace will likely be removed, renamed, and likely moved to a different assembly. Yet, the class names will not need to change since their use of 'PaYaml' is providing a different purpose.
swapnilbhalgat
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue of "Pa" repeating three times. Microsoft.PowerPlatform.PowerApps.Persistence.PaYaml.Serialization.PaYamlSerializer